clawdie/colibri
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 48

fix(test): handle serve() Result in live_socket_check (Sam & Claude)
Some checks failed
CI / rust (pull_request) Has been cancelled
Details
CI / markdown (pull_request) Has been cancelled
Details

Browse source 
PR #75 made socket::serve return io::Result (fail-closed on bind), and updated
the daemon test caller, but the four call sites in colibri-client's
live_socket_check.rs were missed — leaving bare `serve(...).await;` on a
#[must_use] Result. That tripped `unused_must_use`, so
`cargo clippy --workspace --all-targets -- -D warnings` was RED on main.

Add `let _ =` (clippy's own suggestion) at the four spots — these are test
harness server tasks that run until shutdown, so the Result is intentionally
ignored.

Checks: cargo clippy --workspace --all-targets -- -D warnings now clean;
cargo fmt --check.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Sam & Claude 2026-06-15 17:41:57 +02:00
parent 2addce9e01
commit a24260edf6
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/colibri-client/tests/live_socket_check.rs
View file

@ -99,7 +99,7 @@ async fn daemon_client_live_socket_check_with_local_fake_agent() {
let shutdown = state.shutdown_rx.resubscribe();
let server_state = state.clone();
let server = tokio::spawn(async move {
socket::serve(server_state, shutdown).await;
let _ = socket::serve(server_state, shutdown).await;
});
let client = DaemonClient::new(config.socket_path.clone());
@ -150,7 +150,7 @@ async fn colibri_cli_task_commands_use_socket_api() {
let shutdown = state.shutdown_rx.resubscribe();
let server_state = state.clone();
let server = tokio::spawn(async move {
socket::serve(server_state, shutdown).await;
let _ = socket::serve(server_state, shutdown).await;
});
let client = DaemonClient::new(config.socket_path.clone());
@ -213,7 +213,7 @@ async fn poll_tasks_spawns_agent_for_claimed_task() {
let shutdown = state.shutdown_rx.resubscribe();
let server_state = state.clone();
let server = tokio::spawn(async move {
socket::serve(server_state, shutdown).await;
let _ = socket::serve(server_state, shutdown).await;
});
let client = DaemonClient::new(config.socket_path.clone());
@ -316,7 +316,7 @@ async fn harness_double_spawn_session_isolation() {
let shutdown = state.shutdown_rx.resubscribe();
let server_state = state.clone();
let server = tokio::spawn(async move {
socket::serve(server_state, shutdown).await;
let _ = socket::serve(server_state, shutdown).await;
});
let client = DaemonClient::new(config.socket_path.clone());