doctor-upgrade (osa/Codex): client-side colibri upgrade + git-behind fixable check #292

New issue

Closed

opened 2026-06-28 20:00:38 +02:00 by clawdie · 0 comments

clawdie commented

2026-06-28 20:00:38 +02:00

Owner

Host/agent: osa / Codex (Agent B) · Branch from: current main
Design source of truth: docs/wiki/doctor.md (Option A — client-side upgrade)

Client-side self-rebuild + the one fixable: true check.

Blocked on

doctor-engine merge — needs the fixable field in the daemon JSON to know what --fix can act on.

Contract (read the same shape doctor-engine emits)

{"check": "...", "status": "pass|warn|fail", "detail": "...", "fixable": true|false}

Scope

Client-side colibri upgrade subcommand.
Steps: git fetch origin → check HEAD behind origin/main → cargo build --workspace --release → stop daemon → swap binary → start daemon.
Restart is #[cfg]: FreeBSD = service colibri_daemon restart, Linux = systemctl restart colibri-daemon. Everything else (fetch/build/swap) is shared.
Client-side git-behind-origin check — git rev-list --count HEAD..@{u}, integrated into colibri doctor as a client-side supplement (NOT a daemon check). This is the first fixable: true check.
colibri upgrade --check — dry-run; reports whether an upgrade is available without building.
colibri doctor --fix — runs daemon doctor, then for each fixable warn/fail triggers the appropriate fix (→ colibri upgrade).

Files

colibri-client only. Disjoint from doctor-engine; merge order irrelevant except the --fix wiring, which needs doctor-engine's fixable field merged first.

**Host/agent:** osa / Codex (Agent B) · **Branch from:** current `main` **Design source of truth:** [docs/wiki/doctor.md](../src/branch/main/docs/wiki/doctor.md) (Option A — client-side upgrade) Client-side self-rebuild + the one `fixable: true` check. ### Blocked on doctor-engine merge — needs the `fixable` field in the daemon JSON to know what `--fix` can act on. ### Contract (read the same shape doctor-engine emits) ```json {"check": "...", "status": "pass|warn|fail", "detail": "...", "fixable": true|false} ``` ### Scope 1. Client-side `colibri upgrade` subcommand. 2. Steps: `git fetch origin` → check HEAD behind `origin/main` → `cargo build --workspace --release` → stop daemon → swap binary → start daemon. 3. Restart is `#[cfg]`: FreeBSD = `service colibri_daemon restart`, Linux = `systemctl restart colibri-daemon`. Everything else (fetch/build/swap) is shared. 4. **Client-side `git-behind-origin` check** — `git rev-list --count HEAD..@{u}`, integrated into `colibri doctor` as a client-side supplement (NOT a daemon check). This is the first `fixable: true` check. 5. `colibri upgrade --check` — dry-run; reports whether an upgrade is available without building. 6. `colibri doctor --fix` — runs daemon doctor, then for each `fixable` warn/fail triggers the appropriate fix (→ `colibri upgrade`). ### Files `colibri-client` only. Disjoint from doctor-engine; merge order irrelevant except the `--fix` wiring, which needs doctor-engine's `fixable` field merged first.

clawdie referenced this issue from a commit

2026-06-28 20:29:29 +02:00

feat(daemon): doctor engine refactor — typed CheckResult, disk-free, git-version

clawdie referenced this issue

2026-06-28 20:34:02 +02:00

feat(daemon): doctor engine refactor — typed CheckResult, disk-free, git-version #293