From 0062cb13e34d68babd90aa258a11b5cfa841c827 Mon Sep 17 00:00:00 2001 From: Sam & Claude Date: Sun, 28 Jun 2026 10:18:51 +0200 Subject: [PATCH] rename golden tests to fixtures tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace jargon term 'golden tests' with clearer 'fixtures tests' throughout the codebase. This aligns with the project's preference for explicit, understandable terminology over obscure testing jargon. Changes: - Renamed crates/colibri-contracts/tests/golden.rs → fixtures.rs - Updated comments in fixtures.rs and session.rs - Updated docs: AGENTS.md, README.md, colibri.md, index.md - Updated wiki: contracts.md, runtime-inventory.md, sl/contracts.md Note: Kept intentional 'golden line' metaphor in COLIBRI-TOKENOMICS-TRIFECTA.md as it refers to the concept, not the test file. All gates pass: - cargo fmt, clippy, test (14/14 in contracts) - wiki-lint: 187/0 --- AGENTS.md | 4 ++-- README.md | 2 +- crates/colibri-contracts/tests/{golden.rs => fixtures.rs} | 2 +- crates/colibri-daemon/src/session.rs | 2 +- docs/guide/architecture/colibri.md | 2 +- docs/wiki/contracts.md | 2 +- docs/wiki/index.md | 2 +- docs/wiki/runtime-inventory.md | 2 +- docs/wiki/sl/contracts.md | 2 +- packaging/freebsd/port/README.md | 2 +- 10 files changed, 11 insertions(+), 11 deletions(-) rename crates/colibri-contracts/tests/{golden.rs => fixtures.rs} (99%) diff --git a/AGENTS.md b/AGENTS.md index d8d8e5e..efc8da3 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -75,7 +75,7 @@ static linking on FreeBSD (no `openssl-sys` dependency). | Crate | Role | | ----------------------- | ----------------------------------------------------------------------- | -| `colibri-contracts` | Manifest/capability/event schema (golden tests) | +| `colibri-contracts` | Manifest/capability/event schema (fixture tests) | | `colibri-deepseek` | DeepSeek cache-hit probe, prefix metering | | `colibri-runtime` | Host status ingestion, runtime inventory | | `colibri-glasspane` | Agent state machine + event ingestion | @@ -213,7 +213,7 @@ cargo test --workspace cargo clippy --workspace --all-targets -- -D warnings ``` -Golden tests in `crates/colibri-contracts/tests/golden.rs` validate manifest +Fixture tests in `crates/colibri-contracts/tests/fixtures.rs` validate manifest output against reference fixtures. These fixtures are cross-platform — if a Linux-produced manifest differs from FreeBSD 15, investigate and document the cross-platform difference before proceeding. diff --git a/README.md b/README.md index 2a3d3ee..50cb487 100644 --- a/README.md +++ b/README.md @@ -21,7 +21,7 @@ Optional Headroom compression sidecar: `docs/wiki/headroom-sidecar.md`. | ----------------------- | ----------------------------------------------------------------------- | | `colibri` (root) | Workspace root + probe binaries (colibri-probe, runtime-inventory) | | `colibri-mcp` | MCP bridge for editor integration (Zed, Claude Code) via stdio JSON-RPC | -| `colibri-contracts` | JSON schema contracts (golden tests) | +| `colibri-contracts` | JSON schema contracts (fixture tests) | | `colibri-deepseek` | DeepSeek cache-hit probe, prefix metering | | `colibri-runtime` | Host status ingestion, runtime inventory | | `colibri-glasspane` | Agent 5-state machine (zot/pi JSONL events → state) | diff --git a/crates/colibri-contracts/tests/golden.rs b/crates/colibri-contracts/tests/fixtures.rs similarity index 99% rename from crates/colibri-contracts/tests/golden.rs rename to crates/colibri-contracts/tests/fixtures.rs index 4b26e29..6fdee9a 100644 --- a/crates/colibri-contracts/tests/golden.rs +++ b/crates/colibri-contracts/tests/fixtures.rs @@ -1,4 +1,4 @@ -//! Golden tests: the contract structs must accept the real committed manifests +//! Fixture tests: the contract structs must accept the real committed manifests //! (produced by different agents/hosts) and round-trip without data loss. use colibri_contracts::*; diff --git a/crates/colibri-daemon/src/session.rs b/crates/colibri-daemon/src/session.rs index b266736..5dcf16f 100644 --- a/crates/colibri-daemon/src/session.rs +++ b/crates/colibri-daemon/src/session.rs @@ -609,7 +609,7 @@ impl Session { } // --------------------------------------------------------------------------- -// T1.4 golden tests — PromptAssembly + CacheMetrics +// T1.4 fixture tests — PromptAssembly + CacheMetrics // --------------------------------------------------------------------------- #[cfg(test)] diff --git a/docs/guide/architecture/colibri.md b/docs/guide/architecture/colibri.md index ec51f77..bfc08cb 100644 --- a/docs/guide/architecture/colibri.md +++ b/docs/guide/architecture/colibri.md @@ -36,7 +36,7 @@ colibri-daemon — Unix-socket server (the always-on supervisor) | `colibri-skills` | Read-only skills catalog | | `colibri-mcp` | MCP bridge — editor integration + external MCP host | | `colibri-deepseek` | Cache-hit probe + prefix metering for DeepSeek | -| `colibri-contracts` | Manifest/capability/event schemas (golden tests) | +| `colibri-contracts` | Manifest/capability/event schemas (fixture tests) | | `colibri-runtime` | Host status ingestion, runtime inventory | | `clawdie` | Host installer/deployer (ZFS layout, rc.d service) | diff --git a/docs/wiki/contracts.md b/docs/wiki/contracts.md index 6e44226..e27255b 100644 --- a/docs/wiki/contracts.md +++ b/docs/wiki/contracts.md @@ -36,7 +36,7 @@ Schema constants and structs live in `crates/colibri-contracts/src/lib.rs`. ## Golden tests -`crates/colibri-contracts/tests/golden.rs` parses every committed manifest in +`crates/colibri-contracts/tests/fixtures.rs` parses every committed manifest in `manifests/` and asserts round-trip equality. The fixtures are intended to be **cross-platform** — if a manifest produced on Linux differs from one produced on FreeBSD 15, the difference must be understood and documented before it is diff --git a/docs/wiki/index.md b/docs/wiki/index.md index d32b253..7b95ac2 100644 --- a/docs/wiki/index.md +++ b/docs/wiki/index.md @@ -63,7 +63,7 @@ warning. | [layered-soul](./layered-soul.md) | How Colibri consumes the layered-soul reviewed-context repo today vs planned | | [task-board](./task-board.md) | Capability match scoring, cron scheduling, intake drain, SQLite backing | | [quality-gates](./quality-gates.md) | `ci-checks.sh` as the pre-merge gate; why drift reached `main` before | -| [contracts](./contracts.md) | Stable JSON schemas (run-manifest, runtime-inventory, provider-test), golden tests | +| [contracts](./contracts.md) | Stable JSON schemas (run-manifest, runtime-inventory, provider-test), fixture tests | | [store-schema](./store-schema.md) | SQLite coordination schema and migration discipline | | [external-mcp](./external-mcp.md) | MCP bridge for editors + external stdio MCP host; read/write/external-call gates | | [operator-cli](./operator-cli.md) | The `colibri` CLI as a thin typed Unix-socket client over the daemon API | diff --git a/docs/wiki/runtime-inventory.md b/docs/wiki/runtime-inventory.md index 654c77a..77dd535 100644 --- a/docs/wiki/runtime-inventory.md +++ b/docs/wiki/runtime-inventory.md @@ -77,7 +77,7 @@ socket location without recompiling: ## Golden fixtures -`crates/colibri-contracts/tests/golden.rs` parses committed inventory and +`crates/colibri-contracts/tests/fixtures.rs` parses committed inventory and host-status manifests in `manifests/` and round-trips them through the Rust structs. Those fixtures come from real hosts (`osa`, `domedog`, `debby`, the operator USB) and are treated as cross-platform source material. diff --git a/docs/wiki/sl/contracts.md b/docs/wiki/sl/contracts.md index 0ccf2b7..fbfede6 100644 --- a/docs/wiki/sl/contracts.md +++ b/docs/wiki/sl/contracts.md @@ -39,7 +39,7 @@ Konstante shem in strukture živijo v `crates/colibri-contracts/src/lib.rs`. ## Zlati testi -`crates/colibri-contracts/tests/golden.rs` razčleni vsak potrjen manifest v +`crates/colibri-contracts/tests/fixtures.rs` razčleni vsak potrjen manifest v `manifests/` in preveri enakost povratnega zapisa. Primerki so namenjeni **medplatformni** rabi — če se manifest, ustvarjen na Linuxu, razlikuje od tistega na FreeBSD 15, je treba razliko razumeti in dokumentirati, preden se diff --git a/packaging/freebsd/port/README.md b/packaging/freebsd/port/README.md index 61601ac..7deb793 100644 --- a/packaging/freebsd/port/README.md +++ b/packaging/freebsd/port/README.md @@ -73,7 +73,7 @@ cargo clippy --workspace --all-targets -- -D warnings # ✅ zero warnings cargo test --workspace # ✅ 228 passed, 0 failed ``` -228 tests cover all 13 crates including unit, integration, golden, and +228 tests cover all 13 crates including unit, integration, fixture, and live-socket tests. This confirms the `0.11.0` tree compiles and passes on Linux. FreeBSD runtime validation (`cargo test` on FreeBSD 15) is the remaining step before the first poudriere build. -- 2.45.3