From a24260edf64ae9ca28257ec067c87db5c15054fa Mon Sep 17 00:00:00 2001 From: Sam & Claude Date: Mon, 15 Jun 2026 17:41:57 +0200 Subject: [PATCH] fix(test): handle serve() Result in live_socket_check (Sam & Claude) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #75 made socket::serve return io::Result (fail-closed on bind), and updated the daemon test caller, but the four call sites in colibri-client's live_socket_check.rs were missed — leaving bare `serve(...).await;` on a #[must_use] Result. That tripped `unused_must_use`, so `cargo clippy --workspace --all-targets -- -D warnings` was RED on main. Add `let _ =` (clippy's own suggestion) at the four spots — these are test harness server tasks that run until shutdown, so the Result is intentionally ignored. Checks: cargo clippy --workspace --all-targets -- -D warnings now clean; cargo fmt --check. Co-Authored-By: Claude Opus 4.8 --- crates/colibri-client/tests/live_socket_check.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/colibri-client/tests/live_socket_check.rs b/crates/colibri-client/tests/live_socket_check.rs index 2136339..c2c9fd6 100644 --- a/crates/colibri-client/tests/live_socket_check.rs +++ b/crates/colibri-client/tests/live_socket_check.rs @@ -99,7 +99,7 @@ async fn daemon_client_live_socket_check_with_local_fake_agent() { let shutdown = state.shutdown_rx.resubscribe(); let server_state = state.clone(); let server = tokio::spawn(async move { - socket::serve(server_state, shutdown).await; + let _ = socket::serve(server_state, shutdown).await; }); let client = DaemonClient::new(config.socket_path.clone()); @@ -150,7 +150,7 @@ async fn colibri_cli_task_commands_use_socket_api() { let shutdown = state.shutdown_rx.resubscribe(); let server_state = state.clone(); let server = tokio::spawn(async move { - socket::serve(server_state, shutdown).await; + let _ = socket::serve(server_state, shutdown).await; }); let client = DaemonClient::new(config.socket_path.clone()); @@ -213,7 +213,7 @@ async fn poll_tasks_spawns_agent_for_claimed_task() { let shutdown = state.shutdown_rx.resubscribe(); let server_state = state.clone(); let server = tokio::spawn(async move { - socket::serve(server_state, shutdown).await; + let _ = socket::serve(server_state, shutdown).await; }); let client = DaemonClient::new(config.socket_path.clone()); @@ -316,7 +316,7 @@ async fn harness_double_spawn_session_isolation() { let shutdown = state.shutdown_rx.resubscribe(); let server_state = state.clone(); let server = tokio::spawn(async move { - socket::serve(server_state, shutdown).await; + let _ = socket::serve(server_state, shutdown).await; }); let client = DaemonClient::new(config.socket_path.clone()); -- 2.45.3