clawdie/hermes-bsd
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix(skills): add FreeBSD to hermes-agent platform support #5

Merged
clawdie merged 1 commit from fix/skill-platform-freebsd into main 2026-06-21 10:49:49 +02:00
Conversation 0 Commits 1 Files changed 2 +2 -1
clawdie commented 2026-06-21 10:49:05 +02:00
Owner
Copy link

Two changes needed:

  • skills/.../hermes-agent/SKILL.md: add freebsd to platforms list
  • agent/skill_utils.py: add freebsd to PLATFORM_MAP so
    skill_matches_platform() recognizes sys.platform='freebsd*'

Without PLATFORM_MAP entry, the YAML platform declaration alone is not
enough — the runtime check compares against sys.platform prefixes.

What does this PR do?

Related Issue

Fixes #

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

How to Test

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

For New Skills

  • This skill is broadly useful to most users (if bundled) — see Contributing Guide
  • SKILL.md follows the standard format (frontmatter, trigger conditions, steps, pitfalls)
  • No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools)
  • I've tested the skill end-to-end: hermes --toolsets skills -q "Use the X skill to do Y"

Screenshots / Logs

Two changes needed: - skills/.../hermes-agent/SKILL.md: add freebsd to platforms list - agent/skill_utils.py: add freebsd to PLATFORM_MAP so skill_matches_platform() recognizes sys.platform='freebsd*' Without PLATFORM_MAP entry, the YAML platform declaration alone is not enough — the runtime check compares against sys.platform prefixes. ## What does this PR do? <!-- Describe the change clearly. What problem does it solve? Why is this approach the right one? --> ## Related Issue <!-- Link the issue this PR addresses. If no issue exists, consider creating one first. --> Fixes # ## Type of Change <!-- Check the one that applies. --> - [ ] 🐛 Bug fix (non-breaking change that fixes an issue) - [ ] ✨ New feature (non-breaking change that adds functionality) - [ ] 🔒 Security fix - [ ] 📝 Documentation update - [ ] ✅ Tests (adding or improving test coverage) - [ ] ♻️ Refactor (no behavior change) - [ ] 🎯 New skill (bundled or hub) ## Changes Made <!-- List the specific changes. Include file paths for code changes. --> - ## How to Test <!-- Steps to verify this change works. For bugs: reproduction steps + proof that the fix works. --> 1. 2. 3. ## Checklist <!-- Complete these before requesting review. --> ### Code - [ ] I've read the [Contributing Guide](https://github.com/NousResearch/hermes-agent/blob/main/CONTRIBUTING.md) - [ ] My commit messages follow [Conventional Commits](https://www.conventionalcommits.org/) (`fix(scope):`, `feat(scope):`, etc.) - [ ] I searched for [existing PRs](https://github.com/NousResearch/hermes-agent/pulls) to make sure this isn't a duplicate - [ ] My PR contains **only** changes related to this fix/feature (no unrelated commits) - [ ] I've run `pytest tests/ -q` and all tests pass - [ ] I've added tests for my changes (required for bug fixes, strongly encouraged for features) - [ ] I've tested on my platform: <!-- e.g. Ubuntu 24.04, macOS 15.2, Windows 11 --> ### Documentation & Housekeeping <!-- Check all that apply. It's OK to check "N/A" if a category doesn't apply to your change. --> - [ ] I've updated relevant documentation (README, `docs/`, docstrings) — or N/A - [ ] I've updated `cli-config.yaml.example` if I added/changed config keys — or N/A - [ ] I've updated `CONTRIBUTING.md` or `AGENTS.md` if I changed architecture or workflows — or N/A - [ ] I've considered cross-platform impact (Windows, macOS) per the [compatibility guide](https://github.com/NousResearch/hermes-agent/blob/main/CONTRIBUTING.md#cross-platform-compatibility) — or N/A - [ ] I've updated tool descriptions/schemas if I changed tool behavior — or N/A ## For New Skills <!-- Only fill this out if you're adding a skill. Delete this section otherwise. --> - [ ] This skill is **broadly useful** to most users (if bundled) — see [Contributing Guide](https://github.com/NousResearch/hermes-agent/blob/main/CONTRIBUTING.md#should-the-skill-be-bundled) - [ ] SKILL.md follows the [standard format](https://github.com/NousResearch/hermes-agent/blob/main/CONTRIBUTING.md#skillmd-format) (frontmatter, trigger conditions, steps, pitfalls) - [ ] No external dependencies that aren't already available (prefer stdlib, curl, existing Hermes tools) - [ ] I've tested the skill end-to-end: `hermes --toolsets skills -q "Use the X skill to do Y"` ## Screenshots / Logs <!-- If applicable, add screenshots or log output showing the fix/feature in action. -->
clawdie added 1 commit 2026-06-21 10:49:08 +02:00
fix(skills): add FreeBSD to hermes-agent platform support
Some checks failed
Contributor Attribution Check / check-attribution (pull_request) Has been cancelled
Details
Docker Build and Publish / build-amd64 (pull_request) Has been cancelled
Details
Docker Build and Publish / build-arm64 (pull_request) Has been cancelled
Details
History Check / check-common-ancestor (pull_request) Has been cancelled
Details
Lint (ruff + ty) / ruff + ty diff (pull_request) Has been cancelled
Details
Lint (ruff + ty) / ruff enforcement (blocking) (pull_request) Has been cancelled
Details
Lint (ruff + ty) / Windows footguns (blocking) (pull_request) Has been cancelled
Details
Typecheck / typecheck (apps/desktop) (pull_request) Has been cancelled
Details
Typecheck / typecheck (apps/shared) (pull_request) Has been cancelled
Details
Typecheck / typecheck (ui-tui) (pull_request) Has been cancelled
Details
Typecheck / typecheck (web) (pull_request) Has been cancelled
Details
Nix / nix (macos-latest) (pull_request) Has been cancelled
Details
Nix / nix (ubuntu-latest) (pull_request) Has been cancelled
Details
Supply Chain Audit / changes (pull_request) Has been cancelled
Details
Tests / test (1) (pull_request) Has been cancelled
Details
Tests / test (2) (pull_request) Has been cancelled
Details
Tests / test (3) (pull_request) Has been cancelled
Details
Tests / test (4) (pull_request) Has been cancelled
Details
Tests / test (5) (pull_request) Has been cancelled
Details
Tests / test (6) (pull_request) Has been cancelled
Details
Tests / e2e (pull_request) Has been cancelled
Details
Typecheck / typecheck (apps/bootstrap-installer) (pull_request) Has been cancelled
Details
Docker Build and Publish / merge (pull_request) Has been cancelled
Details
Supply Chain Audit / Scan PR for critical supply chain risks (pull_request) Has been cancelled
Details
Supply Chain Audit / Check PyPI dependency upper bounds (pull_request) Has been cancelled
Details
Tests / save-durations (pull_request) Has been cancelled
Details
0e1d4ead04 
Two changes needed:
- skills/.../hermes-agent/SKILL.md: add freebsd to platforms list
- agent/skill_utils.py: add freebsd to PLATFORM_MAP so
  skill_matches_platform() recognizes sys.platform='freebsd*'

Without PLATFORM_MAP entry, the YAML platform declaration alone is not
enough — the runtime check compares against sys.platform prefixes.
clawdie merged commit 3a021f3a41 into main 2026-06-21 10:49:49 +02:00
clawdie deleted branch fix/skill-platform-freebsd 2026-06-21 10:49:49 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: clawdie/hermes-bsd#5
No description provided.
Delete branch "fix/skill-platform-freebsd"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?