zot/packages/tui/render_test.go

104 lines
3.4 KiB
Go
Raw Normal View History

swarm: introduce /swarm dashboard, /btw-style transcript view, and per-session scope A /swarm subsystem for long-running parallel subagents. Each agent runs in its own subprocess against a fresh git worktree (branch swarm/<id>) with its own persistent session file and unix-socket inbox; the parent zot stays in the main session and pokes / observes them via the dashboard. Highlights: - New internal/swarm package: Agent, Spawn/Resume/Kill/Remove, event log (events.jsonl), inbox protocol (listen/dial), worktree manager, exec runner that spawns "zot --swarm-agent ...". - New internal/agent/swarm_agent.go: daemon-mode child entry point. Reuses the standard agent loop but persists turns to the supervisor- chosen session.json and streams events as JSONL on stdout. Mirror to events.jsonl is dormant while the supervisor's stdout pipe is alive so events do not get double-written. - Resume reattaches in place: reuses the same worktree, session, branch and inbox path; carries forward the prior transcript replayed from events.jsonl. Resume no longer re-fires the original Task as a fresh user turn -- that was producing "agent busy; send cancel first" races. - core.NewSessionAtPath plus an openOrCreateSession fallback so the child actually persists its session.json at the supervisor-chosen path on first spawn instead of running with sess==nil. - Dashboard in internal/agent/modes/swarm_dialog.go + swarm_slash.go: list / new / kill / remove / resume / logs / send subcommands plus an interactive picker. Transcript view is /btw-style: an always-on inline editor at the bottom, streaming auto-follow, inline busy spinner with the agent's current activity such as "thinking" or "tool: edit". /model inside the spawn editor pops the global model picker. - Per-session scope: each spawn is stamped with the host session's id and only shows in that session's /swarm dashboard. Pre-upgrade agents -- empty session_id -- remain visible everywhere as a safety net. The active scope is re-applied whenever loadSession swaps sessions. - Resolve falls back to the provider's default model when the persisted cfg.Model is no longer in the catalogue, warns on stderr, and rewrites config.json so the next launch is silent. - ReadEventLog folds back-to-back same-type identical-payload events within 250ms so events.jsonl files polluted by the old supervisor + mirror double-write read back cleanly. - DrawLog gains an idle no-op fast path: identical buffer plus identical cursor = emit nothing, so the terminal's cursor blink keeps ticking in dialogs whose underlying agent is idle. Slash UX: - New /swarm command with subcommands; the suggester picks it up. - README.md documents the full dashboard, CLI, and persistence story, and explicitly notes that /session export does NOT bundle subagents -- their worktree and unix-socket inbox cannot round-trip through a .zotsession. Tests cover: SpawnReq + Resume lifecycle, session-id scoping + persistence, default-child-args spawn vs resume contract, NewSessionAtPath at a fixed path, model fallback when the configured model is gone, swarm dialog behaviour -- auto-open editor, /model in spawn editor, transcript grows without internal scroll, busy spinner, multi-message send -- event-log dedup, swarm emitter dormant-until-orphan, and the DrawLog idle no-op + change-breaks-fast-path invariants.
2026-05-16 11:53:20 +02:00
package tui
import (
"bytes"
"strings"
"testing"
)
// TestDrawLogIdleNoOpEmitsNothing pins the cursor-blink fix: when
// DrawLog is called with the exact same buffer and cursor position
// as the previous call, it must emit ZERO bytes.
//
// The bug this regresses: at the 120ms animation tick the renderer
// used to always emit SeqHideCursor + cursor-position +
// SeqShowCursor, which resets the terminal's blink timer. Faster
// than the OS blink interval, so an idle dialog editor (e.g. a
// re-opened swarm transcript whose agent isn't producing output)
// rendered the caret as a solid non-blinking block.
//
// With the no-op fast path the renderer leaves the screen alone
// on idle frames, letting the terminal run its own blink cycle.
func TestDrawLogIdleNoOpEmitsNothing(t *testing.T) {
var buf bytes.Buffer
r := NewRenderer(&buf)
r.Resize(80, 24)
chat := []string{"hello", "world"}
bottom := []string{"▌ "}
// First draw populates the renderer's cached buffer.
r.DrawLog(chat, bottom, 0, 2)
first := buf.Len()
if first == 0 {
t.Fatal("first DrawLog wrote nothing; setup is broken")
}
buf.Reset()
// Identical second draw: same content, same cursor placement.
r.DrawLog(chat, bottom, 0, 2)
if buf.Len() != 0 {
t.Fatalf("idle re-draw emitted %d bytes; expected 0 so terminal blink keeps ticking\n%q",
buf.Len(), buf.String())
}
}
// TestDrawLogContentChangeBreaksFastPath proves the no-op fast path
// only fires when nothing changed. A buffer mutation must still
// produce output, otherwise streaming agent replies would freeze on
// screen.
func TestDrawLogContentChangeBreaksFastPath(t *testing.T) {
var buf bytes.Buffer
r := NewRenderer(&buf)
r.Resize(80, 24)
r.DrawLog([]string{"hello"}, []string{"▌ "}, 0, 2)
buf.Reset()
// New chat row lands.
r.DrawLog([]string{"hello", "world"}, []string{"▌ "}, 0, 2)
if buf.Len() == 0 {
t.Fatal("content change suppressed by fast path; streaming output would freeze")
}
}
// TestDrawLogCursorMoveBreaksFastPath proves a cursor-only change
// (no buffer change) still produces output. Without this, typing in
// the editor would visually move the caret but the terminal would
// keep drawing it at the old column.
func TestDrawLogCursorMoveBreaksFastPath(t *testing.T) {
var buf bytes.Buffer
r := NewRenderer(&buf)
r.Resize(80, 24)
r.DrawLog([]string{"hi"}, []string{"▌ "}, 0, 2)
buf.Reset()
// Same buffer, different cursor column.
r.DrawLog([]string{"hi"}, []string{"▌ "}, 0, 3)
if buf.Len() == 0 {
t.Fatal("cursor-only change suppressed by fast path; caret would lag behind typing")
}
// And the emitted bytes must at least reposition the cursor.
if !strings.Contains(buf.String(), "\x1b[") {
t.Errorf("cursor move emission missing CSI escapes: %q", buf.String())
}
}
// TestDrawLogResizeForcesFullRedraw confirms a resize invalidates
// the cache so the next DrawLog with identical inputs still emits.
// Resize sets logInit=false; without that, a resize followed by an
// identical buffer would falsely no-op and leave a stale frame.
func TestDrawLogResizeForcesFullRedraw(t *testing.T) {
var buf bytes.Buffer
r := NewRenderer(&buf)
r.Resize(80, 24)
r.DrawLog([]string{"hi"}, []string{"▌ "}, 0, 2)
buf.Reset()
r.Resize(100, 30)
r.DrawLog([]string{"hi"}, []string{"▌ "}, 0, 2)
if buf.Len() == 0 {
t.Fatal("post-resize redraw skipped; the new frame would never reach the terminal")
}
}