Test staged-env shell-quoting helpers; rescope ISO priority 1 to boot validation #66

Merged

clawdie merged 1 commit from staged-env-tests-and-iso-priority-update into main

2026-06-14 15:07:50 +02:00

clawdie commented

2026-06-14 15:07:36 +02:00

Owner

What

Tests: add 8 focused unit tests for the staged-jail env payload helpers in spawner.rs (shell_single_quote, valid_env_key, build_env_script). These generate shell that gets sourced inside the jail launcher and were previously only exercised indirectly via prepare_spawn_command. Tests cover single-quote escaping, shell-metachar neutralization (injection safety), env-key validation (accept/reject), and sorted+quoted script generation.
Docs: re-scope Priority 1 in PRIORITY-HANDOFF-ISO-SPAWN-COST.md. The build-side wiring is done — clawdie-iso build.sh::install_colibri_service stages binaries, installs rc.d, creates the colibri user, and enables the service. Remaining work is boot/runtime validation on FreeBSD, not build wiring. P2/P3 left intact.

Gates

colibri-daemon: 70 tests pass (was 62)
cargo fmt --check: clean
cargo clippy -p colibri-daemon --all-targets -- -D warnings: clean
markdown format gate: clean

🤖 Generated with Claude Code

## What - **Tests:** add 8 focused unit tests for the staged-jail env payload helpers in `spawner.rs` (`shell_single_quote`, `valid_env_key`, `build_env_script`). These generate shell that gets sourced inside the jail launcher and were previously only exercised indirectly via `prepare_spawn_command`. Tests cover single-quote escaping, shell-metachar neutralization (injection safety), env-key validation (accept/reject), and sorted+quoted script generation. - **Docs:** re-scope Priority 1 in `PRIORITY-HANDOFF-ISO-SPAWN-COST.md`. The build-side wiring is done — `clawdie-iso build.sh::install_colibri_service` stages binaries, installs rc.d, creates the `colibri` user, and enables the service. Remaining work is boot/runtime validation on FreeBSD, not build wiring. P2/P3 left intact. ## Gates - `colibri-daemon`: 70 tests pass (was 62) - `cargo fmt --check`: clean - `cargo clippy -p colibri-daemon --all-targets -- -D warnings`: clean - markdown format gate: clean 🤖 Generated with [Claude Code](https://claude.com/claude-code)

clawdie added 1 commit 2026-06-14 15:07:38 +02:00

test(daemon): cover staged-env shell-quoting helpers; rescope ISO priority 1

CI / rust (pull_request) Has been cancelled

Details

CI / markdown (pull_request) Has been cancelled

Details

71048a862d

Add focused unit tests for the staged-jail env payload helpers in
spawner.rs (shell_single_quote, valid_env_key, build_env_script) — they
generate shell injected into the jail launcher and were previously only
exercised indirectly. Tests assert single-quote escaping, metachar
neutralization, env-key validation, and sorted/quoted script generation.

Re-scope PRIORITY-HANDOFF-ISO-SPAWN-COST.md Priority 1: the clawdie-iso
build now stages binaries, installs rc.d, creates the colibri user, and
enables the service (build.sh::install_colibri_service). Remaining work is
boot/runtime validation on FreeBSD, not build wiring. P2/P3 unchanged.

colibri-daemon: 70 tests pass (was 62); fmt + clippy clean; md gate clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>