fix(test): handle serve() Result in live_socket_check (unbreak clippy on main) #78

Merged

clawdie merged 1 commit from fix/serve-result-clippy into main

2026-06-15 17:56:50 +02:00

clawdie commented

2026-06-15 17:42:04 +02:00

Owner

Unblocks main — cargo clippy --workspace --all-targets -- -D warnings is currently RED.

PR #75 made socket::serve return io::Result but missed the 4 call sites in colibri-client/tests/live_socket_check.rs, leaving bare serve(...).await; on a #[must_use] Result → unused_must_use. Added let _ = (clippy's suggestion); these are test server tasks that run until shutdown.

This is the CRITICAL item from the PR #77 audit — fixed here rather than deferred to a handoff.

Checks: clippy --workspace --all-targets -D warnings clean; fmt clean.

🤖 Generated with Claude Code

**Unblocks main** — `cargo clippy --workspace --all-targets -- -D warnings` is currently RED. PR #75 made `socket::serve` return `io::Result` but missed the 4 call sites in `colibri-client/tests/live_socket_check.rs`, leaving bare `serve(...).await;` on a `#[must_use]` Result → `unused_must_use`. Added `let _ =` (clippy's suggestion); these are test server tasks that run until shutdown. This is the CRITICAL item from the PR #77 audit — fixed here rather than deferred to a handoff. Checks: clippy --workspace --all-targets -D warnings clean; fmt clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

clawdie added 1 commit

2026-06-15 17:42:07 +02:00

fix(test): handle serve() Result in live_socket_check (Sam & Claude)

CI / rust (pull_request) Has been cancelled

Details

CI / markdown (pull_request) Has been cancelled

Details

a24260edf6

PR #75 made socket::serve return io::Result (fail-closed on bind), and updated
the daemon test caller, but the four call sites in colibri-client's
live_socket_check.rs were missed — leaving bare `serve(...).await;` on a
#[must_use] Result. That tripped `unused_must_use`, so
`cargo clippy --workspace --all-targets -- -D warnings` was RED on main.

Add `let _ =` (clippy's own suggestion) at the four spots — these are test
harness server tasks that run until shutdown, so the Result is intentionally
ignored.

Checks: cargo clippy --workspace --all-targets -- -D warnings now clean;
cargo fmt --check.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

clawdie merged commit 0d872f199b into main

2026-06-15 17:56:50 +02:00

clawdie deleted branch fix/serve-result-clippy

2026-06-15 17:56:50 +02:00

clawdie referenced this pull request from a commit

2026-06-15 17:56:51 +02:00

fix(test): handle serve() Result in live_socket_check (unbreak clippy on main) (#78)

clawdie referenced this pull request

2026-06-15 17:57:32 +02:00

docs: handoff — rc.d / release gate audit findings #77